Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allows users to skip of verifying SSL certificate #136

Merged
merged 1 commit into from
Jul 20, 2020

Conversation

bednar
Copy link
Contributor

@bednar bednar commented Jul 20, 2020

Closes #134

Proposed Changes

Add kwargs argument verify_ssl to InfluxDBClient that allows users to skip of verifying SSL certificate.

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • pytest tests completes successfully
  • Commit messages are in semantic format
  • Sign CLA (if not already signed)

@bednar bednar added the enhancement New feature or request label Jul 20, 2020
@bednar bednar requested a review from rhajek July 20, 2020 08:12
@codecov-commenter
Copy link

codecov-commenter commented Jul 20, 2020

Codecov Report

Merging #136 into master will decrease coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #136      +/-   ##
==========================================
- Coverage   88.99%   88.94%   -0.05%     
==========================================
  Files          23       23              
  Lines        1863     1864       +1     
==========================================
  Hits         1658     1658              
- Misses        205      206       +1     
Impacted Files Coverage Δ
influxdb_client/client/write_api.py 97.58% <ø> (ø)
influxdb_client/client/influxdb_client.py 98.29% <100.00%> (+0.01%) ⬆️
influxdb_client/client/date_utils.py 80.00% <0.00%> (-20.00%) ⬇️
influxdb_client/rest.py 80.15% <0.00%> (+0.76%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 11f0c35...7595a32. Read the comment docs.

@bednar bednar marked this pull request as ready for review July 20, 2020 08:16
@rhajek rhajek merged commit c1c7f8f into master Jul 20, 2020
@bednar bednar added this to the 1.10.0 milestone Jul 20, 2020
@bednar bednar deleted the feat/verify_ssl branch July 31, 2020 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot connect to InfluxDB with self signed certificate
3 participants