Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add query_data_frame_stream method #121

Merged
merged 3 commits into from
Jun 30, 2020
Merged

Add query_data_frame_stream method #121

merged 3 commits into from
Jun 30, 2020

Conversation

kaheicanaan
Copy link
Contributor

@kaheicanaan kaheicanaan commented Jun 30, 2020 •
edited by bednar
Loading

Closes #114

Add "query_data_frame_stream" method to reduce RAM usage.

  • CHANGELOG.md updated
  • Rebased/mergeable
  • Tests pass
  • Sign CLA (if not already signed)

@codecov-commenter
Copy link

codecov-commenter commented Jun 30, 2020 •
edited
Loading

Codecov Report

Merging #121 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #121      +/-   ##
==========================================
+ Coverage   88.69%   88.71%   +0.01%     
==========================================
  Files          23       23              
  Lines        1823     1826       +3     
==========================================
+ Hits         1617     1620       +3     
  Misses        206      206
Impacted Files Coverage Δ
influxdb_client/client/query_api.py 98.21% <100.00%> (+0.10%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1bb088f...29a9c33. Read the comment docs.

@kaheicanaan
Copy link
Contributor Author

I also modified the original "query_data_frame" method so I didn't add additional test case for this change.

@bednar bednar self-requested a review June 30, 2020 09:34
@bednar bednar added the enhancement New feature or request label Jun 30, 2020
bednar
bednar requested changes Jun 30, 2020
View reviewed changes
Copy link
Contributor

@bednar bednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for PR! It looks perfect.

Could you please update CHANGELOG.md?

@bednar bednar merged commit 3e38699 into influxdata:master Jun 30, 2020
@bednar
Copy link
Contributor

bednar commented Jun 30, 2020

Thanks for PR!

@bednar bednar added this to the 1.9.0 milestone Jun 30, 2020
@kaheicanaan kaheicanaan deleted the stream-support-of-query-data-frame branch June 30, 2020 13:12
rolincova pushed a commit that referenced this pull request Jul 2, 2020
@kaheicanaan @rolincova
feat: Add query_data_frame_stream method (#121)
3de98e0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bednar bednar bednar approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
1.9.0
Development

Successfully merging this pull request may close these issues.

Stream support for query_data_frame
3 participants
@kaheicanaan @codecov-commenter @bednar