Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: serialization of \n, \r and \t to Line Protocol, = is valid sign for measurement name #115

Merged
merged 2 commits into from
Jun 30, 2020
Merged

fix: serialization of \n, \r and \t to Line Protocol, = is valid sign for measurement name #115

merged 2 commits into from
Jun 30, 2020

Conversation

bednar
Copy link
Contributor

@bednar bednar commented Jun 25, 2020 •
edited
Loading

Related to influxdata/influxdb-client-java#127

  • serialization of \n, \r and \t to Line Protocol
  • = is valid sign for measurement name
  • CHANGELOG.md updated
  • Rebased/mergeable
  • Tests pass
  • Sign CLA (if not already signed)

@bednar bednar requested a review from rhajek June 25, 2020 10:42
@codecov-commenter
Copy link

codecov-commenter commented Jun 25, 2020 •
edited
Loading

Codecov Report

Merging #115 into master will increase coverage by 1.07%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #115      +/-   ##
==========================================
+ Coverage   87.67%   88.74%   +1.07%     
==========================================
  Files          22       22              
  Lines        1793     1813      +20     
==========================================
+ Hits         1572     1609      +37     
+ Misses        221      204      -17
Impacted Files Coverage Δ
influxdb_client/client/write/point.py 98.33% <100.00%> (+0.07%) ⬆️
influxdb_client/client/flux_csv_parser.py 91.71% <0.00%> (+0.21%) ⬆️
influxdb_client/api_client.py 67.54% <0.00%> (+0.37%) ⬆️
influxdb_client/configuration.py 84.26% <0.00%> (+1.13%) ⬆️
influxdb_client/rest.py 79.38% <0.00%> (+3.81%) ⬆️
influxdb_client/client/write_api.py 96.63% <0.00%> (+5.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d19ff96...1833b14. Read the comment docs.

@bednar bednar changed the title fix: serialization of \n, \r and \t to Line Protocol fix: serialization of \n, \r and \t to Line Protocol, = is valid sign for measurement name Jun 26, 2020
@bednar bednar force-pushed the fix/escaping-characters branch from b22d582 to 1833b14 Compare June 29, 2020 06:59
rhajek
rhajek approved these changes Jun 30, 2020
View reviewed changes
Copy link
Contributor

@rhajek rhajek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rhajek rhajek merged commit 8c167e9 into master Jun 30, 2020
@bednar bednar deleted the fix/escaping-characters branch July 1, 2020 06:29
@bednar bednar added this to the 1.9.0 milestone Jul 1, 2020
rolincova pushed a commit that referenced this pull request Jul 2, 2020
@bednar @rolincova
fix: serialization of \n, \r and \t to Line Protocol, = is va…
74b4523 
…lid sign for measurement name (#115)

* fix: serialization of `\n`, `\r` and `\t` to Line Protocol

* fix: `=` is valid sign for measurement name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhajek rhajek rhajek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.9.0
Development

Successfully merging this pull request may close these issues.
3 participants
@bednar @codecov-commenter @rhajek