Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): do not retry write upon 'hinted handoff queue not empty' error #458

Merged
merged 2 commits into from
Jun 21, 2022
Merged

fix(core): do not retry write upon 'hinted handoff queue not empty' error #458

merged 2 commits into from
Jun 21, 2022

Conversation

sranka
Copy link
Contributor

@sranka sranka commented Jun 21, 2022 •
edited
Loading

Fixes #457

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • yarn test completes successfully
  • Commit messages are conventional

@sranka sranka added this to the 1.27.0 milestone Jun 21, 2022
@sranka sranka self-assigned this Jun 21, 2022
@sranka sranka marked this pull request as ready for review June 21, 2022 10:38
alespour
alespour approved these changes Jun 21, 2022
View reviewed changes
Copy link

@alespour alespour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

bednar
bednar approved these changes Jun 21, 2022
View reviewed changes
Copy link
Contributor

@bednar bednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🍻

@sranka sranka merged commit b658234 into master Jun 21, 2022
@sranka sranka deleted the 457/hinted_handoff_empty branch June 21, 2022 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bednar bednar bednar approved these changes

@alespour alespour alespour approved these changes

@rhajek rhajek Awaiting requested review from rhajek

@vlastahajek vlastahajek Awaiting requested review from vlastahajek

Assignees

@sranka sranka

Labels
None yet
Projects
None yet
Milestone
1.27.0
Development

Successfully merging this pull request may close these issues.

write API must not be retry if the server returns 'hinted handoff queue not empty' error
3 participants
@sranka @bednar @alespour