Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core/query): simplify retrieval of particular row values #416

Merged
merged 11 commits into from
Mar 3, 2022
Merged

feat(core/query): simplify retrieval of particular row values #416

merged 11 commits into from
Mar 3, 2022

Conversation

sranka
Copy link
Contributor

@sranka sranka commented Mar 1, 2022 •
edited
Loading

This PR simplifies retrieval of particular row values so that

  • there is no need to create a JS object to get selected (and possibly unknown) columns from results, it is simpler and more efficient to use tableMeta.get(row, column)
  • a JS Proxy can be used to transform the row to an object with properties representing column names.

The existing query.ts is modified to show it.

Proposed Changes

Briefly describe your proposed changes:

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • yarn test completes successfully

@sranka sranka force-pushed the feat/core_column_get branch from e0b03e1 to 9376137 Compare March 1, 2022 16:42
@sranka sranka requested review from bednar and vlastahajek March 1, 2022 16:43
@sranka sranka marked this pull request as ready for review March 1, 2022 16:43
bednar
bednar approved these changes Mar 2, 2022
View reviewed changes
Copy link
Contributor

@bednar bednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🍻

@sranka sranka merged commit 5e6cb47 into master Mar 3, 2022
@sranka sranka deleted the feat/core_column_get branch March 3, 2022 16:43
@bednar bednar added this to the 1.24.0 milestone Mar 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bednar bednar bednar approved these changes

@vlastahajek vlastahajek Awaiting requested review from vlastahajek

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.24.0
Development

Successfully merging this pull request may close these issues.
2 participants
@sranka @bednar