Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(core): remove deprecated zlib constants #305

Merged
merged 2 commits into from
Feb 10, 2021
Merged

chore(core): remove deprecated zlib constants #305

merged 2 commits into from
Feb 10, 2021

Conversation

sranka
Copy link
Contributor

@sranka sranka commented Feb 10, 2021 •
edited
Loading

Z_SYNC_FLUSH constant was moved from zlib to zlib.constants sync node v7.0 , so the code in this PR.

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • yarn test completes successfully
  • Commit messages are in semantic format
  • Sign CLA (if not already signed)

@sranka sranka requested a review from vlastahajek February 10, 2021 06:49
@bednar bednar self-requested a review February 10, 2021 09:26
bednar
bednar approved these changes Feb 10, 2021
View reviewed changes
Copy link
Contributor

@bednar bednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sranka sranka merged commit fbfb972 into master Feb 10, 2021
@sranka sranka deleted the chore/zlib_deprecations branch February 10, 2021 09:29
@bednar bednar added this to the 1.11.0 milestone Feb 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bednar bednar bednar approved these changes

@vlastahajek vlastahajek Awaiting requested review from vlastahajek

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.11.0
Development

Successfully merging this pull request may close these issues.
2 participants
@sranka @bednar