Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): optimize UTF-8 encoding #272

Merged
merged 2 commits into from
Nov 2, 2020
Merged

Conversation

sranka
Copy link
Contributor

@sranka sranka commented Oct 30, 2020

This PR optimizes UTF-8 encoding in the browser by using TextEncoder API.

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • yarn test completes successfully
  • Commit messages are in semantic format

@codecov-io
Copy link

codecov-io commented Oct 30, 2020

Codecov Report

Merging #272 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #272   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           28        28           
  Lines         1003      1006    +3     
  Branches       228       228           
=========================================
+ Hits          1003      1006    +3     
Impacted Files Coverage Δ
packages/core/src/impl/browser/FetchTransport.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c1b43cf...77aeba0. Read the comment docs.

@sranka sranka requested a review from vlastahajek October 30, 2020 19:25
@sranka sranka marked this pull request as ready for review October 30, 2020 19:34
@sranka sranka merged commit 824e8f7 into master Nov 2, 2020
@sranka sranka deleted the feat/optimize_toUtf8String branch November 2, 2020 06:01
@bednar bednar added this to the 1.9.0 milestone Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants