Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): require status code 204 in write response #264

Merged
merged 3 commits into from
Oct 9, 2020
Merged

fix(core): require status code 204 in write response #264

merged 3 commits into from
Oct 9, 2020

Conversation

sranka
Copy link
Contributor

@sranka sranka commented Oct 6, 2020 •
edited
Loading

Fixes #263

Proposed Changes

  1. A warning is printed to console on an attempt to configure the client with url having /api/v2 suffix:
    Please remove '/api/v2' context path from InfluxDB base url, using http://test:8096 !
  2. WriteAPI requires status code 204 in HTTP POST response
  3. Transport layer was changed (in a backward-compatible way) to also report the response status code.

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • yarn test completes successfully
  • Commit messages are in semantic format
  • Sign CLA (if not already signed)

@sranka sranka marked this pull request as ready for review October 6, 2020 16:18
@sranka sranka requested a review from vlastahajek October 6, 2020 16:18
vlastahajek
vlastahajek approved these changes Oct 7, 2020
View reviewed changes
Copy link
Contributor

@vlastahajek vlastahajek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sranka sranka added this to the 1.8.0 milestone Oct 9, 2020
@sranka sranka merged commit f8e0eaa into master Oct 9, 2020
@sranka sranka deleted the 263/check_write_response branch October 9, 2020 04:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vlastahajek vlastahajek vlastahajek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.8.0
Development

Successfully merging this pull request may close these issues.

Points no longer written since version 1.6.0
2 participants
@sranka @vlastahajek