Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(core): improve retry strategy and tests #226

Merged
merged 3 commits into from
Jul 31, 2020
Merged

chore(core): improve retry strategy and tests #226

merged 3 commits into from
Jul 31, 2020

Conversation

sranka
Copy link
Contributor

@sranka sranka commented Jul 28, 2020 •
edited
Loading

This PR improves

  • retry strategy (internal) to count with the number of already failed attempts + add a better test for exponential backoff
  • improve test for flux sanitized strings

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • yarn test completes successfully
  • Commit messages are in semantic format
  • Sign CLA (if not already signed)

@sranka sranka changed the title feat(core): improve retry strategy and tests chore(core): improve retry strategy and tests Jul 28, 2020
@sranka sranka requested a review from vlastahajek July 28, 2020 13:20
@sranka sranka merged commit b36d683 into master Jul 31, 2020
@bednar bednar added this to the 1.6.0 milestone Aug 3, 2020
@sranka sranka deleted the feat/retry_delay_strategy branch November 6, 2020 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vlastahajek vlastahajek vlastahajek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.6.0
Development

Successfully merging this pull request may close these issues.
3 participants
@sranka @vlastahajek @bednar