Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core/transport): fall back to 1.8 X-Influxdb-Error HTTP header when no error body is available #209

Merged
merged 3 commits into from
Jun 30, 2020

Conversation

sranka
Copy link
Contributor

@sranka sranka commented Jun 30, 2020

Closes #208

Proposed Changes

  • use InfluxDB1.8 error message from X-Influxdb-Error HTTP header when no message body is sent
  • both node and browser transports changed

Checklist

  • CHANGELOG.md updated
  • A test has been added if appropriate
  • yarn test completes successfully
  • Commit messages are in semantic format
  • Sign CLA (if not already signed)

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@01ed83f). Click here to learn what that means.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             master      #209   +/-   ##
==========================================
  Coverage          ?   100.00%           
==========================================
  Files             ?        26           
  Lines             ?       903           
  Branches          ?       196           
==========================================
  Hits              ?       903           
  Misses            ?         0           
  Partials          ?         0           
Impacted Files Coverage Δ
packages/core/src/impl/browser/FetchTransport.ts 100.00% <100.00%> (ø)
packages/core/src/impl/node/NodeHttpTransport.ts 100.00% <100.00%> (ø)
packages/core/src/query/flux.ts 100.00% <0.00%> (ø)
packages/core/src/impl/linesToTables.ts 100.00% <0.00%> (ø)
packages/core/src/util/currentTime.ts 100.00% <0.00%> (ø)
packages/core/src/Point.ts 100.00% <0.00%> (ø)
packages/core/src/impl/ObservableQuery.ts 100.00% <0.00%> (ø)
packages/core/src/impl/ChunksToLines.ts 100.00% <0.00%> (ø)
...ges/core/src/impl/completeCommunicationObserver.ts 100.00% <0.00%> (ø)
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 01ed83f...8b027e2. Read the comment docs.

@sranka sranka requested a review from vlastahajek June 30, 2020 10:56
@sranka sranka marked this pull request as ready for review June 30, 2020 10:57
@sranka sranka merged commit c79167c into master Jun 30, 2020
@bednar bednar added this to the 1.5.0 milestone Jun 30, 2020
@sranka sranka deleted the 208/1.8_error branch November 6, 2020 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

errors from InfluxDB 1.8 being empty
4 participants