Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): allow to create write API with custom writeOptions #185

Merged
merged 2 commits into from
May 11, 2020

Conversation

sranka
Copy link
Contributor

@sranka sranka commented May 8, 2020

Fixes #184

Proposed Changes

Adds optional writeOptions to getWriteApi

getWriteApi(
    org: string,
    bucket: string,
    precision: WritePrecision = WritePrecision.ns,
    writeOptions?: Partial<WriteOptions>
  ): WriteApi {

Checklist

  • CHANGELOG.md updated
  • A test has been added if appropriate
  • yarn test completes successfully
  • Commit messages are in semantic format
  • Sign CLA (if not already signed)

@sranka sranka requested a review from bednar May 8, 2020 07:01
@codecov-io
Copy link

Codecov Report

Merging #185 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #185   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           26        26           
  Lines          767       768    +1     
  Branches       159       160    +1     
=========================================
+ Hits           767       768    +1     
Impacted Files Coverage Δ
packages/core/src/options.ts 100.00% <ø> (ø)
packages/core/src/InfluxDB.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update afaae56...4d92e93. Read the comment docs.

@bednar bednar added this to the 1.3.0 milestone May 11, 2020
@sranka sranka merged commit 7c3062a into master May 11, 2020
@sranka sranka deleted the feat/createWriteWithOptions branch May 14, 2020 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose WriteAPI Options in getWriteAPI
3 participants