Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: adds httpErrorHandled example and integration test for HttpError #1020

Merged
merged 2 commits into from
Jul 31, 2024

Conversation

karel-rehor
Copy link
Contributor

@karel-rehor karel-rehor commented Jul 29, 2024

Proposed Changes

  • Add an example of using recently added HttpError type
  • Add an extra integration test working with this type

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • yarn test completes successfully
  • Commit messages are conventional
  • Sign CLA (if not already signed)

@karel-rehor karel-rehor requested review from bednar and alespour July 29, 2024 11:10
Copy link

@alespour alespour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice example. I think it should make a CHANGELOG entry.

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (8cfa06c) to head (5a1f2de).
Report is 3 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##            master     #1020   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           35        35           
  Lines         1449      1449           
  Branches       344       344           
=========================================
  Hits          1449      1449           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alespour alespour self-requested a review July 30, 2024 09:50
Copy link

@alespour alespour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice example!

@karel-rehor karel-rehor merged commit 7cb8e43 into master Jul 31, 2024
6 checks passed
@karel-rehor karel-rehor deleted the docs/headersExample branch July 31, 2024 08:16
@bednar bednar added this to the 1.35.0 milestone Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants