Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: improve tests #541

Merged
merged 1 commit into from
May 3, 2023
Merged

chore: improve tests #541

merged 1 commit into from
May 3, 2023

Conversation

eddumelendez
Copy link
Contributor

@eddumelendez eddumelendez commented May 3, 2023 •
edited
Loading

Proposed Changes

  • Remove spring-test dependency
  • Remove usage of ReflectionTestUtils
  • Use assertj's extracting

Checklist

  • Rebased/mergeable
  • mvn test completes successfully
  • Sign CLA (if not already signed)

@eddumelendez
refactor: Improve tests
4cf1130 
* Remove spring-test dependency
* Remove usage of ReflectionTestUtils
* Use assertj's extracting
@bednar bednar changed the title Improve tests chore: improve tests May 3, 2023
bednar
bednar requested changes May 3, 2023
View reviewed changes
Copy link
Contributor

@bednar bednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your awesome PR 👍

Can you please sign the CLA so we can merge this PR?

image

@eddumelendez
Copy link
Contributor Author

done!

@bednar bednar merged commit 64c9538 into influxdata:master May 3, 2023
@bednar
Copy link
Contributor

bednar commented May 3, 2023

@eddumelendez thanks again for your PR 👍

@bednar bednar added this to the 6.9.0 milestone May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bednar bednar bednar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
6.9.0
Development

Successfully merging this pull request may close these issues.
2 participants
@eddumelendez @bednar