Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: serialization of \n, \r and \t to Line Protocol, = is valid sign for measurement name #129

Merged
merged 2 commits into from
Jun 30, 2020
Merged

fix: serialization of \n, \r and \t to Line Protocol, = is valid sign for measurement name #129

merged 2 commits into from
Jun 30, 2020

Conversation

bednar
Copy link
Contributor

@bednar bednar commented Jun 25, 2020 •
edited
Loading

Closes #127

  • serialization of \n, \r and \t to Line Protocol
  • = is valid sign for measurement name
  • CHANGELOG.md updated
  • Rebased/mergeable
  • Tests pass
  • Sign CLA (if not already signed)

@bednar bednar added the bug Something isn't working label Jun 25, 2020
@bednar bednar added this to the 1.10.0 milestone Jun 25, 2020
@bednar bednar requested a review from rhajek June 25, 2020 06:23
@codecov-commenter
Copy link

codecov-commenter commented Jun 25, 2020 •
edited
Loading

Codecov Report

Merging #129 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #129      +/-   ##
============================================
+ Coverage     91.29%   91.31%   +0.01%     
  Complexity      441      441              
============================================
  Files           137      137              
  Lines          5377     5388      +11     
  Branches        201      202       +1     
============================================
+ Hits           4909     4920      +11     
  Misses          389      389              
  Partials         79       79
Impacted Files Coverage Δ Complexity Δ
...src/main/java/com/influxdb/client/write/Point.java 98.02% <100.00%> (+0.15%) 0.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 73de99d...3ce55b6. Read the comment docs.

@bednar bednar force-pushed the fix/escaping-characters branch from b629d74 to baf4008 Compare June 25, 2020 06:44
@bednar bednar changed the title fix: serialization of \n and \r to Line Protocol fix: serialization of \n, \r and \t to Line Protocol Jun 25, 2020
@bednar bednar force-pushed the fix/escaping-characters branch from baf4008 to e9b54bc Compare June 25, 2020 06:46
@bednar bednar force-pushed the fix/escaping-characters branch from e9b54bc to bbbebe5 Compare June 25, 2020 11:01
@bednar bednar mentioned this pull request Jun 26, 2020
Closed
@bednar bednar changed the title fix: serialization of \n, \r and \t to Line Protocol fix: serialization of \n, \r and \t to Line Protocol, = is valid sign for measurement name Jun 26, 2020
rhajek
rhajek approved these changes Jun 30, 2020
View reviewed changes
Copy link
Contributor

@rhajek rhajek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rhajek rhajek merged commit eb90ab5 into master Jun 30, 2020
@bednar bednar deleted the fix/escaping-characters branch July 1, 2020 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhajek rhajek rhajek approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
1.10.0
Development

Successfully merging this pull request may close these issues.

the WriteApi does not check whether a tag value contains unauthorized characters ("\n","\r"...)
3 participants
@bednar @codecov-commenter @rhajek