forked from apache/datafusion
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: workaround exponential planning time bug in DF fork #55
Closed
alamb
wants to merge
3
commits into
influxdata:iox-13280/upgrade-df-ver45
from
alamb:iox-13280/upgrade-df-ver45
Closed
chore: workaround exponential planning time bug in DF fork #55
alamb
wants to merge
3
commits into
influxdata:iox-13280/upgrade-df-ver45
from
alamb:iox-13280/upgrade-df-ver45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
commented
Feb 3, 2025
48fc4f0
to
3e65898
Compare
alamb
commented
Feb 3, 2025
@@ -3552,134 +3574,6 @@ mod tests { | |||
.run() | |||
} | |||
|
|||
#[test] | |||
fn test_union_equivalence_properties_constants_fill_gaps() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are tests of the reverted behavior so I removed them in this commit
I expect clippy to fail due to the arrow 54.1 release -- I expect it till be fixed with the actual datafusion 45 release (as I will port this PR): |
1353531
to
6405b35
Compare
3e65898
to
7f83c65
Compare
This was included in #54 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Targets https://github.com/influxdata/influxdb_iox/pull/13448
As @wiedld mentions in #54 (comment):
The upstream code has been changed so our previous revert can't be applied cleanly
This PR reverts the behavior with a different patch (copy/paste the old code from apache#12562)
Locally when I run the following command without this fix, it fails (timesout)
$ RUST_BACKTRACE=1 TEST_INFLUXDB_JDBC=true TEST_INTEGRATION=1 TEST_INFLUXDB_IOX_CATALOG_DSN=postgresql://postgres@localhost:5432/postgres cargo test --test end_to_end -- read_filter_many_tables
When I have this fix it passes