feat: Google Analytics & feedback component #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yulolimum
reviewed
Jan 30, 2024
| }; | ||
|
|
||
| export default function Feedback({ resource }) { | ||
| const [reaction, setReaction] = useState(null); |
There was a problem hiding this comment.
do we care about any type of persistence for this (local storage or beyond?)? probably not, but just adding an note.
There was a problem hiding this comment.
good callout - I went with the easiest route, but that does allow users to full-refresh and vote again. didn't think it was worth the effort for now, but we can keep an eye on stats and add it later if needed.
FWIW I noticed that other docs sites (reactnative.dev, docs.expo.dev) do the same thing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a modification of #2, but using Google Analytics instead of HappyReact
Reasons:
And the events show up in Google Analytics, which we can report on or send notifications in response to:
