Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add format check for unformatted Go files in CI pipeline #84

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

luohoufu
Copy link
Contributor

What does this PR do

typo imformat output

Rationale for this change

This pull request includes an update to the .github/workflows/pr_check.yml file to improve the workflow when changes are detected after formatting. The most important change is the enhancement of the failure message to provide more detailed instructions to the user.

Enhancements to workflow failure message:

  • .github/workflows/pr_check.yml: Enhanced the failure message to include a detailed explanation and instructions when changes are detected after formatting. This includes setting environment variables, navigating to the workspace, checking the status of .go files, and prompting the user to run 'make format'.

Standards checklist

  • The PR title is descriptive
  • The commit messages are semantic
  • Necessary tests are added
  • Updated the release notes
  • Necessary documents have been added if this is a new feature
  • Performance tests checked, no obvious performance degradation

@medcl medcl changed the title chore: typo imformat output chore: add format check for unformatted Go files in CI pipeline Jan 14, 2025
@luohoufu luohoufu merged commit bdbb753 into main Jan 14, 2025
6 checks passed
@luohoufu luohoufu deleted the format_output_pr branch January 14, 2025 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants