Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add credential settings for agent in enrolling agent #116

Merged
merged 3 commits into from
Feb 11, 2025
Merged

chore: add credential settings for agent in enrolling agent #116

merged 3 commits into from
Feb 11, 2025

Conversation

yaojp123
Copy link
Contributor

@yaojp123 yaojp123 commented Feb 11, 2025 •
edited by luohoufu
Loading

What does this PR do

  1. add credential settings for agent in enrolling agent
  2. add collection mode to cluster editing

Rationale for this change

Standards checklist

  • The PR title is descriptive
  • The commit messages are semantic
  • Necessary tests are added
  • Updated the release notes
  • Necessary documents have been added if this is a new feature
  • Performance tests checked, no obvious performance degradation

@yaojp123 yaojp123 changed the title chore: add credential settings for agent when enroll agent chore: add credential settings for agent in enrolling agent Feb 11, 2025
luohoufu
luohoufu approved these changes Feb 11, 2025
View reviewed changes
Copy link
Contributor

@luohoufu luohoufu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luohoufu luohoufu merged commit d2a3ec0 into main Feb 11, 2025
4 of 5 checks passed
@luohoufu luohoufu deleted the chore-agent branch February 11, 2025 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luohoufu luohoufu luohoufu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yaojp123 @luohoufu