Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: refactoring yuque connector #62

Merged
merged 1 commit into from
Jan 20, 2025
Merged

refactor: refactoring yuque connector #62

merged 1 commit into from
Jan 20, 2025

Conversation

medcl
Copy link
Member

@medcl medcl commented Jan 20, 2025

What does this PR do

This pull request introduces several changes to the plugins/connectors/yuque package, primarily focusing on enhancing the collection and indexing of book table of contents (TOC) and improving error handling. The most important changes include the addition of a new struct BookToc, modifications to the collectBooks and collectDocs functions to handle TOC data, and the addition of a new configuration option to skip TOC indexing.

Enhancements to book TOC handling:

  • plugins/connectors/yuque/book.go: Added a new struct BookToc to represent the table of contents of a book, including fields for UUID, type, title, URL, and hierarchical relationships.

Modifications to collection functions:

Error handling improvements:

New configuration option:

Rationale for this change

Standards checklist

  • The PR title is descriptive
  • The commit messages are semantic
  • Necessary tests are added
  • Updated the release notes
  • Necessary documents have been added if this is a new feature
  • Performance tests checked, no obvious performance degradation

@RainyNight9 RainyNight9 merged commit b13c8ea into main Jan 20, 2025
2 checks passed
@RainyNight9 RainyNight9 deleted the yuqueuedd branch January 20, 2025 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants