Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: refactoring connectors #58

Merged
merged 3 commits into from
Jan 19, 2025
Merged

refactor: refactoring connectors #58

merged 3 commits into from
Jan 19, 2025

Conversation

medcl
Copy link
Member

@medcl medcl commented Jan 19, 2025

What does this PR do

This pull request includes significant changes to the plugins/connectors/google_drive plugin, focusing on enhancing the handling of multiple data sources and improving file type recognition. The most important changes include updating function signatures to include datasourceID, modifying the getIcon function to support additional file types, and commenting out unused code.

Enhancements to data source handling:

Improvements to file type recognition:

Code cleanup:

Rationale for this change

Standards checklist

  • The PR title is descriptive
  • Necessary tests are added
  • Updated the release notes
  • Necessary documents have been added if this is a new feature
  • Performance tests checked, no obvious performance degradation

@bindiego bindiego merged commit 219ad28 into main Jan 19, 2025
2 checks passed
@bindiego bindiego deleted the misc branch January 19, 2025 12:22
@bindiego bindiego self-assigned this Jan 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants