Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do
This pull request includes significant changes to the
plugins/connectors/google_drive
plugin, focusing on enhancing the handling of multiple data sources and improving file type recognition. The most important changes include updating function signatures to includedatasourceID
, modifying thegetIcon
function to support additional file types, and commenting out unused code.Enhancements to data source handling:
plugins/connectors/google_drive/api.go
: Updated function signatures to includedatasourceID
and modified thegetTenantKey
function to accommodate this new parameter. [1] [2] [3]plugins/connectors/google_drive/files.go
: Updated thestartIndexingFiles
function and related calls to includedatasourceID
. [1] [2] [3]Improvements to file type recognition:
plugins/connectors/google_drive/files.go
: Enhanced thegetIcon
function to support additional Google Drive file types and common file formats.Code cleanup:
plugins/connectors/google_drive/api.go
: Commented out unused code related totenantID
anduserID
in theoAuthRedirect
function. [1] [2]plugins/connectors/yuque/collect.go
: Simplified thegetIconKey
function by removing thecategory
parameter.] The commit messages are semanticRationale for this change
Standards checklist