This repository has been archived by the owner on Oct 16, 2024. It is now read-only.
Get vanilla tests passing in Java 9 #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Java 9 no longer makes the `@Generated` annotation available by default.
|
|
|
You make an excellent point. |
j-baker
approved these changes
Nov 20, 2016
| private static final class GeneratedAnnotationExcerpt extends Excerpt { | ||
| private final Class<?> generator; | ||
|
|
||
| GeneratedAnnotationExcerpt(Class<?> generator) { |
There was a problem hiding this comment.
you should probably have a test that the Generated annotation doesn't show up in JDK9. Or, is that way more work?
There was a problem hiding this comment.
Impossible, really—we don't run unit tests in JDK 9.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have two choices regarding the
@Generatedannotation: omit it entirely henceforth, or conditionally exclude it in Java 9+. As James points out, since@Generatedis a compile-time annotation, we won't accidentally be generating non–Java 9–compliant libraries from older compilers, so conditionally omitting it should be sufficient.Included in this PR:
@Generatedannotation if it's not available