Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(config): correct path case in Inertia page_paths #719

Open
wants to merge 1 commit into
base: 2.x
Choose a base branch
from

Conversation

rdehnhardt
Copy link

  • Updated page_paths config to use lowercase 'pages' directory.
  • Ensures consistency with naming conventions and avoids errors.

- Updated `page_paths` config to use lowercase 'pages' directory.
- Ensures consistency with naming conventions and avoids errors.
@RobertBoes
Copy link
Contributor

Personally I don't think this should be changed in the Inertia package. Inertia allows for configuration, so consumers should instead update the paths they use. This would also affect the docs, as that uses the current path. It would also affect other packages, such as Breeze, Jetstream and other third party packages. So changing this default would cause a significantly large breaking change.

@rdehnhardt
Copy link
Author

I explain a bit better here (#718) and, in a way, I agree with you. However, as I explain in the issue, the New Laravel Starter Kits have a new standard, and if this is the new standard, every new installation will have to include the config, which I also mention in the issue!

@RobertBoes
Copy link
Contributor

Then imho, those starter kits should have the config with the correct path. That's what one would do with a manual install and different paths as well.

That way there would be no breaking change, and it would work in all cases.

With this change it will fix one minor thing, while breaking lots of other implementations.

@rdehnhardt
Copy link
Author

It's not a problem for me. As I mentioned in the issue, I've already added the configuration to the folder. However, I imagine this problem could be reported many more times in the future! My intention was simply to remove a step of complexity from the inertia installation from now on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants