Update rust backend to pyo3 0.22.6 #257
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://pyo3.rs/v0.23.4/migration.html#from-021-to-022 for more details. This passes the tests using the rust backend on my local Mac setup except for one test that is also failing on CI.
I also tried updating to 0.23 as well but the update to PyO3 0.23 is a little trickier. Here are the compiler errors I see: https://gist.github.com/ngoldbaum/467cebc15f9ec79b8930c389ddfea115
Most of the errors are similar to other PyO3 0.23 migrations I've done, but you probably want to think about how to safely add
unsafe impl Syncimplementations for the various types that are flagged under 0.23 because they're notSync.