spdx=0.4.1
dependency increases MSRV to 1.52
#415
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running
cargo install pyoxidizer
with Rust 1.50.0 on Windows 10 failed, complaining about use of unstable featurestr_split_once
.The usage occurs in
spdx::lexer::find_document_and_license_ref
. The change was introduced in[email protected]
as part of removing dependence onregex
/lazy_static
. That's awesome for compilation-speed/binary-size, but now all depending crates transitively depend on Rust >=1.52, the version which stabilizedstr::split_once
. This isn't a big deal for me personally, because I don't have a reason to use an older toolchain (I just hadn't upgraded for a bit). But, since this project's MSRV is 1.46, I thought this might become an issue for someone else.python-packaging
,tugger-licensing
, andtugger-licensing-net
all depend onspdx = "0.4"
. Cloning the repo and building from source succeeds; the Cargo.lock pinsspdx=0.4.0
. However,cargo install --path pyoxidizer
fails just likecargo install pyoxidizer
. Apparently,cargo install
doesn't respectCargo.lock
unless you use--locked
.Constraining
spdx = "= 0.4.0"
fixes this, at the cost of shackling users with Rust >=1.52 to the old implementation. On the other hand, that may be desirable for consistency between MSRV up to current version.Alternatively, the documentation could add a suggestion to use
cargo install --locked
for older toolchains.