-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated sumpy and boxtree to arraycontext branches #179
Draft
alexfikl
wants to merge
12
commits into
inducer:main
Choose a base branch
from
alexfikl:towards-array-context
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
245f916
point requirements to modified branches
alexfikl b9eefd7
add skeleton array context class
alexfikl a2a29a8
use pytential.PyOpenCLArrayContext in tests and examples
alexfikl 27e7c39
preliminary porting to new sumpy and boxtree
alexfikl a1d954e
add actx to docs
alexfikl 8789f9d
remove uses of DataDeviceRecord
alexfikl 1b3ab0a
update docs to not mention cl.Array
alexfikl ed86f91
fix porting errors
alexfikl 954fefa
rip out timing collection
alexfikl c644202
move cost model example
alexfikl 063f004
ignore boxtree doc error
alexfikl 04d83e2
fix porting
alexfikl File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,89 @@ | ||
__copyright__ = "Copyright (C) 2022 Alexandru Fikl" | ||
|
||
__license__ = """ | ||
Permission is hereby granted, free of charge, to any person obtaining a copy | ||
of this software and associated documentation files (the "Software"), to deal | ||
in the Software without restriction, including without limitation the rights | ||
to use, copy, modify, merge, publish, distribute, sublicense, and/or sell | ||
copies of the Software, and to permit persons to whom the Software is | ||
furnished to do so, subject to the following conditions: | ||
|
||
The above copyright notice and this permission notice shall be included in | ||
all copies or substantial portions of the Software. | ||
|
||
THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR | ||
IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, | ||
FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE | ||
AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER | ||
LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, | ||
OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN | ||
THE SOFTWARE. | ||
""" | ||
|
||
from meshmode.array_context import ( # noqa: F401 | ||
PyOpenCLArrayContext as MeshmodePyOpenCLArrayContext) | ||
from sumpy.array_context import ( # noqa: F401 | ||
PyOpenCLArrayContext as SumpyPyOpenCLArrayContext, | ||
make_loopy_program) | ||
from boxtree.array_context import dataclass_array_container # noqa: F401 | ||
from arraycontext.pytest import ( | ||
_PytestPyOpenCLArrayContextFactoryWithClass, | ||
register_pytest_array_context_factory) | ||
|
||
__doc__ = """ | ||
.. autoclass:: PyOpenCLArrayContext | ||
""" | ||
|
||
|
||
# {{{ PyOpenCLArrayContext | ||
|
||
class PyOpenCLArrayContext(SumpyPyOpenCLArrayContext): | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. How should this inherit from the |
||
def transform_loopy_program(self, t_unit): | ||
kernel = t_unit.default_entrypoint | ||
options = kernel.options | ||
|
||
if not options.return_dict or not options.no_numpy: | ||
raise ValueError( | ||
"loopy kernels passed to 'call_loopy' must have 'return_dict' " | ||
"and 'no_numpy' options set. Did you use 'make_loopy_program' " | ||
f"to create the kernel '{kernel.name}'?") | ||
|
||
# FIXME: this probably needs some proper logic | ||
from meshmode.array_context import _transform_loopy_inner | ||
transformed_t_unit = _transform_loopy_inner(t_unit) | ||
|
||
if transformed_t_unit is not None: | ||
return transformed_t_unit | ||
|
||
return t_unit | ||
|
||
# }}} | ||
|
||
|
||
# {{{ pytest | ||
|
||
def _acf(): | ||
import pyopencl as cl | ||
ctx = cl.create_some_context() | ||
queue = cl.CommandQueue(ctx) | ||
|
||
return PyOpenCLArrayContext(queue, force_device_scalars=True) | ||
|
||
|
||
class PytestPyOpenCLArrayContextFactory( | ||
_PytestPyOpenCLArrayContextFactoryWithClass): | ||
actx_class = PyOpenCLArrayContext | ||
|
||
def __call__(self): | ||
# NOTE: prevent any cache explosions during testing! | ||
from sympy.core.cache import clear_cache | ||
clear_cache() | ||
|
||
return super().__call__() | ||
|
||
|
||
register_pytest_array_context_factory( | ||
"pytential.pyopencl", | ||
PytestPyOpenCLArrayContextFactory) | ||
|
||
# }}} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to remove this once the boxtree changes go in.