-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Request for an optional "Apply for an account with eduGAIN" button #665
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Not necessarily with this PR, but we should probably use the same terminology commonly found on web services: "sign up" or "register". |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Enable the "Apply for an account with EduGAIN" button only if SAML is enabled.
e.g. <c:if test="${loginPageConfiguration.samlEnabled}">
Make sense. This will be visible only if SAML is enabled now. |
I think there's not only EduGAIN as a SAML provider. If you configured another SAML remote provider you'll see a non sense button with the label "Apply for an account with EduGAIN" or am I wrong? And if we add this button for each OIDC/SAML provider configured the login page could contain lots of buttons. Probably we need to add a configuration parameter for each SAML endpoint configured that enables or not its own, specific "Apply for an account with ..." button. |
Kudos, SonarCloud Quality Gate passed! |
Resolves #522
Added an anchor tag with the content saying "Apply for an account with eduGAIN".