-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ajouter le champ libre “description et méthodologie de calcul” aux indicateurs prédéfinis #3313
Closed
elisfainstein
wants to merge
189
commits into
main
from
feature/TET-3025-description-field-in-indicateurs-predefinis
Closed
Ajouter le champ libre “description et méthodologie de calcul” aux indicateurs prédéfinis #3313
elisfainstein
wants to merge
189
commits into
main
from
feature/TET-3025-description-field-in-indicateurs-predefinis
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…"Ajouter les actions classées <statut>" est activée lors du changement de statut de l'action
…anier d'une collectivité déjà activée
… si l'utilisateur n'est pas rattaché à celle-ci
…un utilisateur lors de la transformation du panier en plan d'action
…er mon inscription" pour les utilisateurs non encore rattachés à une collectivité
…les utilisateurs non encore rattachés à une collectivité
* fix: change branch name processing to always be lowercase and tolerate a longer name with hyphens * fix: fix typo * fix: change max name length * fix: remove hyphens in branch name * fix: limit branch name to 22 characters * fix: convert - to _ and limit name length to 14 char * fix: fix typo * fix: remove - to _ conversion * doc: add koyeb validation rule explanation
…changed by this PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Méthodologie :
L'objectif final est de recâbler le code de façon à ce que le champ "description et méthode de calcul" présent dans les indicateurs perso écrive non plus dans
description
de la tableindicateur_definition
, mais danscommentaire
de la tableindicateur_collectivite
.On fait le changement progressivement en suivant le pattern
expand and contract
(doc).Cette PR correspond à la 2e étape du pattern.
Fonctionnement :
indicateur perso existant : le champ "description et méthode de calcul"
description
de la tableindicateur_definition
et danscommentaire
de la tableindicateur_collectivite
;description
de la tableindicateur_definition
;indicateur perso nouvellement créé : idem ;
indicateur pré-défini : le champ
commentaire
de la tableindicateur_collectivite
. Il n'écrit pas dansdescription
de la tableindicateur_definition
car cette colonne abrite déjà des descriptions pré-écrites, qui s'affichent dans le petiti
d'informations dans l'UI.commentaire
de la tableindicateur_collectivite
.