Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Disable the export data button if the poll has less than 3 participants #663

Merged
merged 3 commits into from
Aug 27, 2024

Conversation

bjlaa
Copy link
Contributor

@bjlaa bjlaa commented Aug 13, 2024

No description provided.

@bjlaa bjlaa requested a review from florianpanchout August 13, 2024 09:00
@bjlaa bjlaa self-assigned this Aug 13, 2024
Copy link

vercel bot commented Aug 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nosgestesclimat ✅ Ready (Inspect) Visit Preview Aug 26, 2024 2:23pm

Copy link

github-actions bot commented Aug 13, 2024

Report for the pull request #663


🌐 Translation status

UI's texts

Language Nb. missing translations Status
en Ø ✔️
es Ø ✔️

FAQ's questions

Language Nb. missing translations Status
en Ø ✔️
es Ø ✔️

You will find more information about the translation in the dedicated file.

@bjlaa
Copy link
Contributor Author

bjlaa commented Aug 26, 2024

@paulsouche ready to review !

@@ -25,7 +25,13 @@ export default function ExportDataButton({
}: ButtonProps & Props) {
const [isLoading, setIsLoading] = useState(false)

const isDisabled = isLoading || simulationRecaps?.length < 3
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pour moi c'est pas caché. L'utilisateur va pas comprendre pourquoi c'est disabled. La carte spécifie cacher

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oui tu as raison !

@bjlaa bjlaa merged commit 242060c into preprod Aug 27, 2024
7 checks passed
@bjlaa bjlaa deleted the NGC-1083 branch August 27, 2024 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants