Add attachments, and incident updates onto incidents stream #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rliddler
force-pushed
the
rob/add-attachments-on-incidents
branch
from
5733a85 to
66b082f
Compare
This API is per incident, so makes sense to nest this information into the incident schema itself as we go. The updates we have a separate table but we can also insert them nested into the incident itself - you can literally basically do 1 query for everything then!
rliddler
force-pushed
the
rob/add-attachments-on-incidents
branch
from
66b082f to
fc1f5e2
Compare
rliddler
changed the title
isaacseymour
approved these changes
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The attachments API is per incident, so makes sense to nest this information into the incident schema itself as we go.
The updates we have a separate table but we can also insert them nested into the incident itself - you can literally basically do 1 query for everything then!
Shot of an attachment on an incident:
Shot of some updates:
