Add the discovery flag and method, along with model package #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isaacseymour
approved these changes
Oct 18, 2023
| @@ -113,3 +70,17 @@ func (o *OutputLogger) Log(op *Output) error { | |||
|
|
|||
| return nil | |||
| } | |||
|
|
|||
| func (o *OutputLogger) CataLog(catalog *Catalog) error { | |||
There was a problem hiding this comment.
Suggested change
| func (o *OutputLogger) CataLog(catalog *Catalog) error { | |
| func (o *OutputLogger) Catalog(catalog *Catalog) error { |
..?
There was a problem hiding this comment.
This was a terrible joke from me - it's a catalog log 😢
We want to be able to output schemas when we run in discovery mode so this PR adds that flag along with the associated method to do so. It just goes through the streams and calls Schema() along with adding a few other fields. In the future we will also need to generate metadata as part of that (and consume the file back in). The other change here is the start of pulling out the models we use to generate schemas and serialize data into their own package. This PR just pulls out the schema itself - but a followup will add a bunch of models representing entities in our API that we expose. Will just follow a simple pattern of having a schema / serialize method on them.
rliddler
force-pushed
the
rob/add-discovery-mode-and-model-basics
branch
from
86ce907 to
01e72ec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to be able to output schemas when we run in discovery mode so this PR adds that flag along with the associated method to do so.
It just goes through the streams and calls Schema() along with adding a few other fields. In the future we will also need to generate metadata as part of that (and consume the file back in).
The other change here is the start of pulling out the models we use to generate schemas and serialize data into their own package.
This PR just pulls out the schema itself - but a followup will add a bunch of models representing entities in our API that we expose. Will just follow a simple pattern of having a schema / serialize method on them.