Support 'components' section in openapi 3.0.0 #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brucify
force-pushed
the
openapi_3_0_0_components
branch
from
083ce3a to
fe4d3f0
Compare
brucify
force-pushed
the
openapi_3_0_0_components
branch
from
fe4d3f0 to
60eae30
Compare
elbrujohalcon
requested changes
Dec 17, 2019
src/cowboy_swagger.erl
Outdated
| @@ -68,6 +69,12 @@ | |||
| -type metadata() :: trails:metadata(swagger_map()). | |||
| -export_type([swagger_map/0, metadata/0]). | |||
|
|
|||
| -define(SWAGGER_2_0, swagger_2_0). | |||
There was a problem hiding this comment.
We don't really like to use macros for these things. Can you just use the atoms everywhere and trust dialyzer? :)
elbrujohalcon
approved these changes
Dec 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
add_definition/1always adds to thedefinitions:section in swagger.json andschema/1hardcodes to fetch from<<"#/definitions/", DefinitionName/binary>>.Open API 3.0.0 has removed the
#/definitions/section and introduced#/components/schemas/(Components Section)This causes:
This PR adds support to point
add_definition/1andschema/1to "components" section ifopenapi: "3.0.0"is defined. Forswagger: "2.0", it will still add to "definitions" section.