-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement in_toto_run #7
Merged
Merged
Changes from 1 commit
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
6b9cd30
:new: Add Skeleton for InTotoRun
joyliu-q d8de0e5
:new: Fill-in skeleton, add recordartifacts & runcommand
joyliu-q fd99f0a
:broom: Clean code, propagate errors
joyliu-q a6170a3
:shirt: Remove Unnecessary Return Statement
joyliu-q 6a35d8b
:broom: Return status code, correct doc, cosmetics
joyliu-q 2c01646
:heavy_check_mark: Make tests pass
joyliu-q 27e12d3
:new: Add run_dir parameter, canonicalize path
joyliu-q cb93298
:zap: Better path handling & test_record_artifacts
joyliu-q 6e0ddf5
:new: Add example usage for in_toto_run
joyliu-q fdfab27
:tada: Handle symbolic links & record_artifacts breakdown
joyliu-q eff788c
:new: Add hash_algorithms parameter
joyliu-q 640b370
:heavy_check_mark: Add hash_algorithms to example
joyliu-q 46d9a42
:tada: Add path normalization using path_clean
joyliu-q 890372c
:new: Add Link Generation, Rename Metablock
joyliu-q 228bc35
Merge branch 'master' of https://github.com/in-toto/in-toto-rs into a…
joyliu-q 8e6fb7d
:books: Add to Documentation
joyliu-q 99762ee
:bug: Add path-clean as dependency
joyliu-q 2e83e00
:bug: Make Keys a Reference
joyliu-q 402083d
:new: Add runlib tests & placeholders
joyliu-q 714b8c1
:new: Clean-up & Add tests
joyliu-q 2805e39
:bug: More contextual err handling in run_command
joyliu-q 7eae8c9
:art: Add run_command check for empty slice passed
joyliu-q 02d44c1
:new: Add back typ field to preserve type & name
joyliu-q 6639884
:heavy_check_mark: Pass tests for absolute paths
joyliu-q 59e2b14
:heavy_check_mark: Remove symdir
joyliu-q f8531f1
:bug: Address comments & make test pass on Github
joyliu-q 26023c9
:broom: Delete symbolic link to file
joyliu-q f5e6479
:broom: Delete symbolic link to folder
joyliu-q File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not entirely sure about the logic following this. If cmd_args is empty, then return empty? when would this happen?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If no
cmd_args
are provided (e.g. input is&[]
), thelet executable = cmd_args[0];
line would fail. Because of the data type ofcmd_args
is&[&str]
, providing an empty slice as the input is definitely possible (maybe to denote for no cmd_args supplied). In that case, there would be no byproducts and an empty BTreeMap would be returned.