Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Radiation protective armor and medicine now effect message frequency #1797

Merged
merged 2 commits into from
Feb 28, 2025

Conversation

TheGrimbeeper
Copy link

@TheGrimbeeper TheGrimbeeper commented Feb 28, 2025

Hooked into the existing damage modifier system to allow detection of applicable radiation modifiers, so you won't feel your skin melting when you are in the CE hardsuit.

Also:

  • if you can't take damage, you won't see the messages
  • adds a 'virtualDamage' field to the damage modify event to allow seeing what modifiers exist without actually dealing damage to things like shields.
  • makes the popup chance calculate based on damage received in the current irradiation event, rather than over the last second - should prevent any issues from variable game tickrate/lag

Hooked into the existing damage modifier system to allow detection of applicable radiation modifiers.

Also:
- if you can't take damage, you won't see the messages
- adds a 'virtualDamage' field to the damage modify event to allow seeing what modifiers exist without actually dealing damage to things like shields.
Copy link

@mqole mqole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merging this without looking i trust you to have tested this. if it breaks then onus is on me

@mqole
Copy link

mqole commented Feb 28, 2025

also removing cl because the og radiation thing hasnt been published

@mqole mqole merged commit 3626f02 into impstation:master Feb 28, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants