feat: Added greedy option for skipEmptyLines to handle blank lines an… #932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d commas-only lines
thisismayuresh
temporarily deployed
to
Development
GitHub Actions
Inactive
|
View your CI Pipeline Execution ↗ for commit 38bd803.
☁️ Nx Cloud last updated this comment at |
|
View your CI Pipeline Execution ↗ for commit 38bd803.
☁️ Nx Cloud last updated this comment at |
chavda-bhavik
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The skipEmptyLines option in Papa Parse was previously set to true, which only skips fully blank lines. However, lines containing just commas (e.g., ,,,,, ,,,,,) were not being handled correctly and would still be parsed as valid, non-empty lines, causing issues in CSV parsing and was causing empty records.
Changes Made:
Added the 'greedy' option to the skipEmptyLines configuration.
This update ensures that both blank lines and lines containing only commas (e.g., ,,,,, ,,,,,) are treated as empty and skipped during parsing, improving how CSV files are handled.