Skip to content

Commit

Permalink
feat Updated config variable names (#917)
Browse files Browse the repository at this point in the history
  • Loading branch information
chavda-bhavik authored Jan 5, 2025
2 parents 68f2028 + 1978472 commit acdac0a
Show file tree
Hide file tree
Showing 5 changed files with 14,660 additions and 18,173 deletions.
8 changes: 4 additions & 4 deletions apps/widget/src/components/Common/Table/Table.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,7 @@ interface TableProps {
onCheckAll?: (checked: boolean) => void;
onValueChange?: (row: number, prop: string, oldVal: any, newVal: any) => void;
onRowCheck?: (rowIndex: number, recordIndex: number, checked: boolean) => void;
disableCheckBox?: boolean;
hideCheckBox?: boolean;
}

export const Table = forwardRef<HotTableClass, TableProps>(
Expand All @@ -183,7 +183,7 @@ export const Table = forwardRef<HotTableClass, TableProps>(
headings,
columnDefs,
data,
disableCheckBox,
hideCheckBox,
beforePaste,
columnDescriptions,
allChecked,
Expand All @@ -193,8 +193,8 @@ export const Table = forwardRef<HotTableClass, TableProps>(
minSpareRows,
frozenColumns = 2,
onValueChange,
// Conditionally set selectEnabled based on disableCheckBox
selectEnabled = disableCheckBox === undefined ? true : !disableCheckBox,
// Conditionally set selectEnabled based on hideCheckBox
selectEnabled = hideCheckBox === undefined ? true : !hideCheckBox,
}: TableProps,
gridRef
) => {
Expand Down
12 changes: 6 additions & 6 deletions apps/widget/src/components/widget/Phases/Phase3/Phase3.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -61,9 +61,9 @@ export function Phase3(props: IPhase3Props) {
isCompleteImportLoading,
setShowAllDataValidModal,
setShowDeleteConfirmModal,
disableFindAndReplaceButton,
disableDeleteButton,
disableCheckBox,
hideFindAndReplaceButton,
hideDeleteButton,
hideCheckBox,
} = usePhase3({ onNext: onNextClick });
const tableWrapperRef = useRef<HTMLDivElement>() as React.MutableRefObject<HTMLDivElement>;
const [tableWrapperDimensions, setTableWrapperDimentions] = useState({
Expand Down Expand Up @@ -117,11 +117,11 @@ export function Phase3(props: IPhase3Props) {
]}
/>
<Group spacing="xs">
{!disableFindAndReplaceButton && (
{!hideFindAndReplaceButton && (
<Button onClick={() => setShowFindReplaceModal(true)}>{texts.PHASE3.FIND_REPLACE}</Button>
)}

{!disableDeleteButton && (
{!hideDeleteButton && (
<Button
color="red"
disabled={!selectedRowsRef.current.size}
Expand Down Expand Up @@ -209,7 +209,7 @@ export function Phase3(props: IPhase3Props) {
columnDefs={columnDefs}
allChecked={allChecked}
columnDescriptions={columnDescriptions}
disableCheckBox={disableCheckBox}
hideCheckBox={hideCheckBox}
/>
</Stack>
<Pagination page={page} total={totalPages} onChange={onPageChange} />
Expand Down
10 changes: 5 additions & 5 deletions apps/widget/src/hooks/Phase3/usePhase3.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ export function usePhase3({ onNext }: IUsePhase3Props) {
const newColumnDefs: HotItemSchema[] = [];
const newHeadings: string[] = [];

if (!config?.disableCheckBox) {
if (!config?.hideCheckBox) {
newHeadings.push('*');
updatedFrozenColumns++;
newColumnDefs.push({
Expand All @@ -79,7 +79,7 @@ export function usePhase3({ onNext }: IUsePhase3Props) {
});
}

if (!config?.disableSrNo) {
if (!config?.hideSrNo) {
newHeadings.push('Sr. No.');
updatedFrozenColumns++;
newColumnDefs.push({
Expand Down Expand Up @@ -304,8 +304,8 @@ export function usePhase3({ onNext }: IUsePhase3Props) {
totalRecords: uploadInfo.totalRecords ?? undefined,
invalidRecords: uploadInfo.invalidRecords ?? undefined,
refetchReviewData: () => refetchReviewData([page, type]),
disableFindAndReplaceButton: config?.disableFindAndReplaceButton,
disableDeleteButton: config?.disableDeleteButton,
disableCheckBox: config?.disableCheckBox,
hideFindAndReplaceButton: config?.hideFindAndReplaceButton,
hideDeleteButton: config?.hideDeleteButton,
hideCheckBox: config?.hideCheckBox,
};
}
8 changes: 4 additions & 4 deletions packages/client/src/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -181,10 +181,10 @@ export type DeepPartial<T> = T extends object
export type ValueOf<T> = T[keyof T];

export declare type WidgetConfig = {
disableFindAndReplaceButton?: boolean;
disableDeleteButton?: boolean;
disableCheckBox?: boolean;
disableSrNo?: boolean;
hideFindAndReplaceButton?: boolean;
hideDeleteButton?: boolean;
hideCheckBox?: boolean;
hideSrNo?: boolean;
};

export type CustomTexts = DeepPartial<typeof WIDGET_TEXTS>;
Expand Down
Loading

0 comments on commit acdac0a

Please sign in to comment.