test: use reserved testing domain example.test
(RFC 2606)
#492
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Error message
The test
test_qr_code_scanned_handle_siopv2_authorization_request
runs successfully locally, but fails in CI.Expected:
Error while fetching configuration: failed to parse response into JSON value
==> The external system could be reached, but the response cannot be parsed into a JSON value
Actual:
Error while fetching configuration: failed to get response from resource url: https://example.com/.well-known/did-configuration.json
==> The external system could not be reached at all
Root cause
One of the problems for this inconsistency is that an actually existing domain is used for many integration tests:
example.com
. It thereby needs to be treated as "external dependency" - even if it's just for testing purposes.Depending on whether the test execution environment has internet access or not, the HTTP responses when trying to fetch from that resource are differing.
Solution
There are TLDs specifically reserved for testing, such as
.test
or.example
.Links to any relevant issues
Be sure to reference any related issues by adding
fixes issue #
.How the change has been tested
Describe the tests that you ran to verify your changes.
Make sure to provide instructions for the maintainer as well as any relevant configurations.
Definition of Done checklist
Add an
x
to the boxes that are relevant to your changes.