Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade svelte to v5 #479

Open
wants to merge 12 commits into
base: dev
Choose a base branch
from
Open

chore: upgrade svelte to v5 #479

wants to merge 12 commits into from

Conversation

maiertech
Copy link
Member

@maiertech maiertech commented Feb 5, 2025

Description of change

Upgrade:

  • svelte to v5
  • vite to v6
  • @sveltejs/vite-plugin-svelte to v5

Refactoring:

  • All svelte-check and lint errors resolved in preparation for ci: add svelte-check #184.
  • Svelte 5 uses different types than Svelte 4. I use new type Component a lot. Component is backwards compatible with Svelte 4 components.
  • Svelte 5 does not want self-closing tags. I added a couple of closing tags.
  • No Svelte 4 to Svelte 5 conversion refactoring. Svelte 5 should be backwards compatible with Svelte 4.

Links to any relevant issues

How the change has been tested

Test the following flows with the desktop version. Even better if you can deploy UniMe to your phone. Flows to test:

Explore as much as possible side paths, e.g. tap on a credential, tap on an issuer, tap on activity etc.

Definition of Done checklist

Add an x to the boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@maiertech maiertech marked this pull request as ready for review February 5, 2025 20:42
@maiertech maiertech changed the title Upgrade Svelte to v5 chore: Upgrade Svelte to v5 Feb 11, 2025
@maiertech maiertech marked this pull request as draft February 12, 2025 15:12
@maiertech maiertech self-assigned this Feb 12, 2025
@maiertech maiertech mentioned this pull request Feb 14, 2025
5 tasks
@maiertech maiertech changed the title chore: Upgrade Svelte to v5 chore: Upgrade svelte to v5 Feb 14, 2025
@maiertech maiertech changed the title chore: Upgrade svelte to v5 chore: upgrade svelte to v5 Feb 14, 2025
@maiertech maiertech marked this pull request as ready for review February 18, 2025 13:47
@daniel-mader daniel-mader added Dependencies Issues related to an update of a dependency file Frontend This issue pertains to the UniMe frontend. labels Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dependencies Issues related to an update of a dependency file Frontend This issue pertains to the UniMe frontend.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade Svelte to v5
2 participants