Code

Refactor variadics#638

Code

Open

kkysen wants to merge 17 commits intomasterimmunant/c2rust:masterfrom kkysen/refactor-variadicsimmunant/c2rust:kkysen/refactor-variadicsCopy head branch name to clipboard

+59-90

Commits

Commits on Aug 23, 2022

• Refactor is_va_decl to use .map() and .unwrap_or_default().

  kkysen

  committed
  3866a89

  Copy full SHA for 3866a89

• Refactored match_vacopy with ?.

  kkysen

  committed
  593da11

  Copy full SHA for 593da11

• Replaced an as &str with a .as_str().

  kkysen

  committed
  67deb33

  Copy full SHA for 67deb33

• Refactored if ... { return None; }s in match arms into match if guards.

  kkysen

  committed
  0560612

  Copy full SHA for 0560612

• Replaced args.len() == n and then args[0], etc. with matching on the args.as_slice() itself.

  kkysen

  committed
  c2e1136

  Copy full SHA for c2e1136

• Reformatted the match_vapart match after refactoring it.

  kkysen

  committed
  f9eec5f

  Copy full SHA for f9eec5f

• Refactored out repeated matching on __builtin_va_* into a .strip_prefix("__builtin_va_")?.

  kkysen

  committed
  51b3d91

  Copy full SHA for 51b3d91

• Improved doc comments on inner variadic matching functions.

  kkysen

  committed
  15575c3

  Copy full SHA for 15575c3

• Made the variadic-matching inner functions closures instead so we don't have to pass the same args to all of them.

  kkysen

  committed
  35701ce

  Copy full SHA for 35701ce

• Renamed the local ast_context to ast for brevity since it's used so many times.

  kkysen

  committed
  578dc62

  Copy full SHA for 578dc62

• Removed non-local control flow (return None) and variable declarations from match_or! using ? and clear lets instead. This also allows inlay type hints to work now.

  kkysen

  committed
  66cebb5

  Copy full SHA for 66cebb5

Commits on Aug 24, 2022

• Fixed confusing "* pointer" language in docs, which could be a **. Now just * is used, no "pointer".

  kkysen

  committed
  8fae26f

  Copy full SHA for 8fae26f

• Favor .unwrap_or(false) over .unwrap_or_default() as it's less clear that bool::default() == false.

  kkysen

  committed
  eaccb5c

  Copy full SHA for eaccb5c

• Revert "Refactored out repeated matching on __builtin_va_* into a .strip_prefix("__builtin_va_")?."

  Show description for b4428a3
  kkysen

  committed
  b4428a3

  Copy full SHA for b4428a3

• Refactored out let ast = &self.ast_context for brevity in fn match_vapart, like already done in fn match_vastart.

  kkysen

  committed
  0e48fdb

  Copy full SHA for 0e48fdb

Commits on Aug 26, 2022

• Re-formatted match_or!s onto 1 line each. 2 lines with an indented 2nd line would be preferable, but rustfmt says no.

  kkysen

  committed
  8ac1538

  Copy full SHA for 8ac1538

• Revert "Refactor is_va_decl to use .map() and .unwrap_or_default()."

  Show description for 2439ed4
  kkysen

  committed
  2439ed4

  Copy full SHA for 2439ed4