Ticket 62119: Fixes invalid url output #131
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Please see ticket 62119
minitest/minitest@9a57c52 ! Renamed MiniTest to Minitest. Your pinkies will thank me.
These tests are for commit 94c89f1
anthony0030
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When making a URL with a blank parameter, it would outpoint an unneeded =
Before this PR...
https://demo.imgix.net/images/demo.png?mark=&h=200&w=200&s=XXXXXXXXXXXXXX
https://demo.imgix.net/images/demo.png?mark=
After this PR...
https://demo.imgix.net/images/demo.png?mark&h=200&w=200&s=XXXXXXXXXXXXXX
https://demo.imgix.net/images/demo.png?mark
Checklist
PS: This commit also fixes the tests not running due to the change in Minitest, MiniTest -> Minitest