Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update htmlSafe import to @ember/template rather than @ember/string #223

Conversation

rahulk94
Copy link
Contributor

@rahulk94 rahulk94 commented Jan 21, 2022

Description

Update htmlSafe import to @ember/template as the current usage is invalid when using [email protected]+. This fixes the following warnings when using these Ember versions (note that [email protected] is an LTS so its likely to be the version people use for a while yet).

WARNING in ./node_modules/ember-cli-imgix/components/imgix-bg.js 111:11-19
export 'htmlSafe' (imported as 'htmlSafe') was not found in '@ember/string' (possible exports: camelize, capitalize, classify, dasherize, decamelize, getString, getStrings, loc, setStrings, underscore, w)
 @ ./components/imgix-bg.js 1:0-78 1:0-78
 @ ./assets/my-app 864:9-45

Bug Fix

  • All existing unit tests are still passing (if applicable)
  • Add new passing unit tests to cover the code introduced by your PR
  • Add some steps so we can test your bug fix
  • The PR title is in the conventional commit format: e.g. fix(<area>): fixed bug #issue-number

Steps to test

This has only been tested using unit tests. It probably is worth testing this against a real world ember app prior to merging (or we send it as its unlikely this will break things).

@rahulk94 rahulk94 requested a review from a team as a code owner January 21, 2022 04:29
@commit-lint
Copy link

commit-lint bot commented Jan 21, 2022

Contributors

rahulk94

Commit-Lint commands

You can trigger Commit-Lint actions by commenting on this PR:

  • @Commit-Lint merge patch will merge dependabot PR on "patch" versions (X.X.Y - Y change)
  • @Commit-Lint merge minor will merge dependabot PR on "minor" versions (X.Y.Y - Y change)
  • @Commit-Lint merge major will merge dependabot PR on "major" versions (Y.Y.Y - Y change)
  • @Commit-Lint merge disable will desactivate merge dependabot PR
  • @Commit-Lint review will approve dependabot PR
  • @Commit-Lint stop review will stop approve dependabot PR

Copy link
Contributor

@frederickfogerty frederickfogerty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@frederickfogerty frederickfogerty merged commit da22519 into imgix:main Jan 21, 2022
@rahulk94 rahulk94 mentioned this pull request Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants