fix: remove fallback src from srcset list #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jayeb
approved these changes
Dec 13, 2019
updates tests add myself as contributor as per PR template, woo fix: add back a test that accidentally got removed
srhcrete
force-pushed
the
removes-fallback-srcset
branch
from
28c0d6e to
6074870
Compare
sherwinski
approved these changes
Dec 16, 2019
sherwinski
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes issue #69 - we're currently adding a "sizeless" URL to the end of the srcset attributes as a "fallback source" which is incorrect. The "fallback source" for an image element should be provided in the src attribute, not at the end of the srcset list.
To Reproduce
N/A
Expected Behavior
Every item in the srcset list should include a size descriptor, which in our case is always a width value or a resolution multiplier. Tests are still passing.