-
Notifications
You must be signed in to change notification settings - Fork 630
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changelog for v0.24 #1656
Changelog for v0.24 #1656
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Pointed out some typos.
3413749
to
9af380b
Compare
Upgrading |
Does this mean we'll get a new release soon? 😃 |
@HeroicKatora I don't know if this is related to For context: I'm trying to replicate fuzzy hashes using your |
Time for some findings. It looks like the quickcheck based test diverged from the implementation in that the special case of ensuring a non-empty result was never introduced. Somehow, the previous version (
This case should resize one dimension to Diff for the fix to the implementation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally we shouldn't be mixing code changes, dependency bumps, and the changelog updates all in the same PR. However, everything here looks good to me.
22fef61
to
63489d5
Compare
Closes: #1433