Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional clip #349

Merged
merged 5 commits into from
May 24, 2020
Merged

Optional clip #349

merged 5 commits into from
May 24, 2020

Conversation

tomwyr
Copy link
Contributor

@tomwyr tomwyr commented May 23, 2020

Currently it's not possible to clip only one side of the chart. Either you need to clip everything or not clip at all.
E.g. I'd like to hide my chart line below left labels area but prevent dot at value 0 from being partially invisible at the same time:

chart

This PR replaces clipToBorder with clipData where clipping of each side can be enabled/disabled.

@imaNNeo
Copy link
Owner

imaNNeo commented May 24, 2020

Hi, there was a problem with master, that's why this branch is failed.
I've just fixed the problem, please update your branch with master,
Thanks.

@imaNNeo
Copy link
Owner

imaNNeo commented May 24, 2020

Excellent,
It is the most straight forward PR I've ever had.
Well done.

@imaNNeo
Copy link
Owner

imaNNeo commented May 24, 2020

And please change target to the dev branch,
because we merge new features into the dev branch, then we bump up the version and ship it into the master with a new version code and tag.

@tomwyr tomwyr changed the base branch from master to dev May 24, 2020 15:31
@imaNNeo imaNNeo merged commit 12be214 into imaNNeo:dev May 24, 2020
@imaNNeo
Copy link
Owner

imaNNeo commented May 24, 2020

Thanks for your awesome PR.
Hope to see more from you!

@tomwyr
Copy link
Contributor Author

tomwyr commented May 24, 2020

Thanks for quick review and this awesome package.
Cheers!

@tomwyr tomwyr deleted the optional-clip branch May 24, 2020 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants