Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the ability to select the RadarChart shape (circle or polygon) #1052

Merged
merged 1 commit into from
Jun 10, 2022

Conversation

FlorianArnould
Copy link
Contributor

@FlorianArnould FlorianArnould commented Jun 7, 2022

Use it like this :

RadarChart(
  RadarChartData(
    ...,
    radarShape: RadarShape.polygon, // nullable arg defaulting to RadarShape.circle
  ),
)
Polygon Circle (now default / previously the only one)
image image

@imaNNeo
Copy link
Owner

imaNNeo commented Jun 9, 2022

Actually everything is perfect.
I will merge it ASAP.

@codecov
Copy link

codecov bot commented Jun 9, 2022

Codecov Report

Merging #1052 (87de751) into master (2de36af) will increase coverage by 0.08%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1052      +/-   ##
==========================================
+ Coverage   86.14%   86.23%   +0.08%     
==========================================
  Files          45       45              
  Lines        2758     2775      +17     
==========================================
+ Hits         2376     2393      +17     
  Misses        382      382              
Impacted Files Coverage Δ
lib/src/chart/radar_chart/radar_chart_painter.dart 100.00% <100.00%> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@imaNNeo
Copy link
Owner

imaNNeo commented Jun 9, 2022

Don't forget to update our radar_chart.md file

@FlorianArnould
Copy link
Contributor Author

I don't know what's you process for merging the PRs, but I would like to implement this feature #883 too.
Could it be possible to merge this before to avoid the conflicts ?

@imaNNeo imaNNeo merged commit 9542241 into imaNNeo:master Jun 10, 2022
@imaNNeo
Copy link
Owner

imaNNeo commented Jun 10, 2022

I just merged it. Thanks for contributing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants