Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added: Damm Algorithm to Algorithm package(issue #114) #240

Merged
merged 2 commits into from
Dec 14, 2024

Conversation

nour-awad
Copy link
Contributor

@nour-awad nour-awad commented Dec 7, 2024

  • Implement tests for calculating checksum digits for String, int, and long inputs.
  • Add tests for generating full numbers with checksums and validating them.
  • Ensure proper handling of invalid inputs (empty string, non-digit characters).
  • Include tests for both valid and invalid checksum scenarios.
  • Verify functionality for different data types: String, int, and long.
    Open for modification at any time

- Implement tests for calculating checksum digits for String, int, and long inputs.
- Add tests for generating full numbers with checksums and validating them.
- Ensure proper handling of invalid inputs (empty string, non-digit characters).
- Include tests for both valid and invalid checksum scenarios.
- Verify functionality for different data types: String, int, and long.

These tests improve coverage and ensure that the Damm algorithm implementation behaves as expected.
@nour-awad nour-awad changed the title Added: Damm Algorithm and unit tests for DammSnippet (issue #114) Added: Damm Algorithm to Algorithm package(issue #114) Dec 7, 2024
Copy link

sonarqubecloud bot commented Dec 7, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@iluwatar iluwatar merged commit 36081db into iluwatar:master Dec 14, 2024
1 check passed
@iluwatar
Copy link
Owner

Looks good! Thank you for the contribution 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants