Use frame_offset instead of frame for Cue Point position #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would you be able to create a small test file from the MixPre and add it to the test cases? |
|
I will check tomorrow. This is mostly just about adding it to |
|
Yes if you can please add your file to the |
As described in issue iluvcapra#9 the function cue_points() didn't display the expected frame values for cue points created on a Sound Devices MixPre-Series recorder. The file added by this commit (sounddevices_6_cue_points.wav) is short and mono channel, but has 6 cue points in it. The expected frames for the cue points are: 0: 90112 1: 176128 2: 237568 3: 294912 4: 380928 5: 385024
|
Okay I added it. I also took the freedom to delete all (invisible on macOS) |
|
Hey just a Q- what is this test file |
|
Also for the file you added, could you please document for me here what you expect the value to be? I'll add a unit test for it! |
And unit tests for cue metadata.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in issue #9 cuepoints from a Sound Devices MixPre-Series recorder are returned with the wrong frame value of always 0. I tried the suggested fix in a fork and it worked for me as expected with both files. I tried running the tests, but as I am currently on a windows machine I guess I am out of luck with that one.
Feel free to modify, deny, etc this PR if there are things which I overlooked.