Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename the idefics2 module #128

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
- Bumped "breaking" dependencies on MTEB and Transformers version and made the corresponding changes in the code
- Casted Image dtype in ColPali due to breaking 4.46 transformers update
- Added a "num_image_tokens" kwarg to the `ColQwen2Processor` to allow for different image resolutions
- Rename `x_idefics_2_y` files to `x_idefics2_y` to match the `transformers` naming convention

### Fixed

Expand Down
2 changes: 1 addition & 1 deletion colpali_engine/collators/visual_retriever_collator.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

from PIL.Image import Image

from colpali_engine.models.idefics_2 import ColIdefics2Processor
from colpali_engine.models.idefics2 import ColIdefics2Processor
from colpali_engine.models.paligemma import ColPaliProcessor
from colpali_engine.utils.processing_utils import BaseVisualRetrieverProcessor

Expand Down
2 changes: 1 addition & 1 deletion colpali_engine/models/__init__.py
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
from .idefics_2 import BiIdefics2, ColIdefics2, ColIdefics2Processor
from .idefics2 import BiIdefics2, BiIdefics2Processor, ColIdefics2, ColIdefics2Processor
from .paligemma import BiPali, BiPaliProcessor, BiPaliProj, ColPali, ColPaliProcessor
from .qwen2 import BiQwen2, BiQwen2Processor, ColQwen2, ColQwen2Processor
2 changes: 2 additions & 0 deletions colpali_engine/models/idefics2/__init__.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
from .biidefics2 import BiIdefics2, BiIdefics2Processor
from .colidefics2 import ColIdefics2, ColIdefics2Processor
2 changes: 2 additions & 0 deletions colpali_engine/models/idefics2/biidefics2/__init__.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
from .modeling_biidefics2 import BiIdefics2
from .processing_biidefics2 import BiIdefics2Processor
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

import torch

from colpali_engine.models.idefics_2.colidefics_2.processing_colidefics_2 import ColIdefics2Processor
from colpali_engine.models.idefics2.colidefics2.processing_colidefics2 import ColIdefics2Processor


class BiIdefics2Processor(ColIdefics2Processor):
Expand Down
2 changes: 2 additions & 0 deletions colpali_engine/models/idefics2/colidefics2/__init__.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
from .modeling_colidefics2 import ColIdefics2
from .processing_colidefics2 import ColIdefics2Processor
2 changes: 0 additions & 2 deletions colpali_engine/models/idefics_2/__init__.py

This file was deleted.

1 change: 0 additions & 1 deletion colpali_engine/models/idefics_2/biidefics_2/__init__.py

This file was deleted.

2 changes: 0 additions & 2 deletions colpali_engine/models/idefics_2/colidefics_2/__init__.py

This file was deleted.

Loading