-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace dictzip with idzip #512
Conversation
There are Upd: Done. |
Let's use both. Check for idzip first, then check for dictzip. Because the whole point of this function is convenience (user can compress the files himself after convert). If user has dictzip, why bother installing anything else? We also don't like to break compatibility. Also please:
|
Thanks. |
Oh, I thought to update the test to test an Also I would suggest to include And one other thing. It seems reasonable to me to get an error when |
Alternative
izip is maintained Python alternative to
dictzip
utility.Rationale
The pure python dependency instead of a binary, easy to obtain, no need to subprocess it.
Changes
dictzip
call replaced withidzip
, whilerunDictzip
contract are kept as close todictzip
version as possible.stardict
writer compresses also a syn file when exists anddictzip
opt isTrue
for consistence.runDictzip
.Notes
idzip
had been tried on the DPD stardict. It does the job as same efficient as thedictzip
, even a few percents faster. On a 1G random binary blob it shows a bit worse performance thandictzip
do.P. S.: I will be out of a PC for a few next days, so sorry for possible long response time.