Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doesn't compile on latest Rust #210

Closed
danielzgtg opened this issue Oct 8, 2020 · 5 comments · Fixed by #211
Closed

Doesn't compile on latest Rust #210

danielzgtg opened this issue Oct 8, 2020 · 5 comments · Fixed by #211

Comments

@danielzgtg
Copy link

uom doesn't compile on latest Rust.

Rust Version

$ rustup update
info: syncing channel updates for 'nightly-x86_64-unknown-linux-gnu'
info: checking for self-updates

  nightly-x86_64-unknown-linux-gnu unchanged - rustc 1.49.0-nightly (91a79fb29 2020-10-07)

info: cleaning up downloads & tmp directories

Example project

cargo new test123
cd test123
echo 'uom = "0.29.0"' >> Cargo.toml
cargo build 2>&1 | tee log.txt

Build error

log.txt
@iliekturtles
Copy link
Owner

Thanks for the report. I'm setting up a minimally reproducible example to find out if this is a uom bug or something that should be reported upstream.

@iliekturtles iliekturtles mentioned this issue Oct 9, 2020
Closed
@iliekturtles
Copy link
Owner

Reported upstream: rust-lang/rust#77638 (comment). Explicit bounds can be added to resolve the issue in uom, but I'm going to wait until discussion completes in the issue above to determine if this is the right solution.

@iliekturtles
Copy link
Owner

Per rust-lang/rust#77638 this isn't going to be fixed upstream. Working on a fix in uom now. I'm planning to release a new version to crates.io once this is completed.

@iliekturtles
Copy link
Owner

Code changes completed, but I ran out of time writing the commit message. Will try to get a PR pushed tomorrow.

matchai added a commit to starship/starship that referenced this issue Oct 13, 2020
@matchai
ci: temporarily disable nightly tests
a8264cd 
Disabled until the following issue is fixed:
iliekturtles/uom#210
iliekturtles added a commit that referenced this issue Oct 16, 2020
@iliekturtles
Resolve now-ambiguous trait bounds.
62f07bf 
rust-lang/rust#73905 introduced changes to typechecking that made
previously accepted trait bounds where a trait was automatically chosen
now ambiguous. Resolves #210.

See rust-lang/rust#77638 (comment) for
additional discussion.
@iliekturtles iliekturtles mentioned this issue Oct 16, 2020
Merged
iliekturtles added a commit that referenced this issue Oct 18, 2020
@iliekturtles
Resolve now-ambiguous trait bounds.
2f6d6c8 
rust-lang/rust#73905 introduced changes to typechecking that made
previously accepted trait bounds where a trait was automatically chosen
now ambiguous. Resolves #210.

See rust-lang/rust#77638 (comment) for
additional discussion.
@iliekturtles
Copy link
Owner

Thanks again for the report. v0.30.0 just published to crates.io with this fix.

@Gerschtli Gerschtli mentioned this issue Oct 18, 2020
Merged
@andytom andytom mentioned this issue Oct 20, 2020
Merged
5 tasks
@danielzgtg danielzgtg mentioned this issue Oct 21, 2020
Closed
@iliekturtles iliekturtles mentioned this issue Nov 21, 2020
Closed
iliekturtles added a commit that referenced this issue Jan 4, 2021
@iliekturtles
Resolve now-ambiguous trait bounts in non-autoconvert code.
252370d 
`autoconvert` code fixed in 2f6d6c8.
Resolves #234, #210.
@iliekturtles iliekturtles mentioned this issue Jan 4, 2021
Merged
iliekturtles added a commit that referenced this issue Jan 4, 2021
@iliekturtles
Resolve now-ambiguous trait bounts in non-autoconvert code.
8d92cf4 
`autoconvert` code fixed in 2f6d6c8.
Resolves #234, #210.
chipbuster pushed a commit to chipbuster/starship that referenced this issue Jan 14, 2021
@matchai @chipbuster
ci: temporarily disable nightly tests
9adfefd 
Disabled until the following issue is fixed:
iliekturtles/uom#210
@iliekturtles iliekturtles mentioned this issue Oct 18, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Resolve now-ambiguous trait bounds. iliekturtles/uom
2 participants
@iliekturtles @danielzgtg