Fix off-by-one error in laplacian smoothing #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…th a reference implementation of laplacian smoothing. (Previously, rounds=1 resulted in no smoothing, rounds=2 resulted in only 1 round, etc.)
k-dominik
approved these changes
Jun 23, 2020
k-dominik
added a commit
to k-dominik/volumina
that referenced
this pull request
Jun 23, 2020
Due to a bug (ilastik/marching_cubes#23) in the marching cubes repo, smoothing rounds were off by one. In order to retain consistent behavior we have to reduce the number of smoothing rounds.
k-dominik
added a commit
to k-dominik/volumina
that referenced
this pull request
Jun 23, 2020
Due to a bug (ilastik/marching_cubes#23) in the marching cubes repo, smoothing rounds were off by one. In order to retain consistent behavior we have to reduce the number of smoothing rounds. Co-Authored-By: Stuart Berg <[email protected]>
|
Thanks for merging, and for the new release.
Thanks, same to you. I'm doing well, all things considered. Working from home and taking care of a 1-year-old is not great for productivity, but I can't really complain. |
k-dominik
added a commit
to ilastik/volumina
that referenced
this pull request
Jul 23, 2020
Due to a bug (ilastik/marching_cubes#23) in the marching cubes repo, smoothing rounds were off by one. In order to retain consistent behavior we have to reduce the number of smoothing rounds. Co-Authored-By: Stuart Berg <[email protected]>
k-dominik
added a commit
to k-dominik/volumina
that referenced
this pull request
Sep 28, 2020
Due to a bug (ilastik/marching_cubes#23) in the marching cubes repo, smoothing rounds were off by one. In order to retain consistent behavior we have to reduce the number of smoothing rounds. Co-Authored-By: Stuart Berg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an off-by-one error in
laplacian_smoothing.cpp, which was caused by an unnecessary swap of the final results with the temporary arrays that are used for intermediate values.The final round of smoothing was being computed, but then it was thrown out. So, previously,
rounds=1resulted in no smoothing at all,rounds=2resulted in only 1 round, etc.Since I happen to have a pandas-based implementation of
laplacian_smoothing, I added it to the test suite as a reference implementation. I also corrected the reference mesh.Side note: After fixing this, you may want to update this call in volumina, or your meshes will be slightly smoother than they were before. (Reduce it from 4 to 3)